This repository has been archived by the owner on May 31, 2021. It is now read-only.
Update Dockerfile to handle FLOOD_BASE_URI #879
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates Dockerfile to correctly handle FLOOD_BASE_URI environment variable.
Unlike other environment variables in config.docker.js, FLOOD_BASE_URI must be used during
docker build
, not onlydocker run
.To enable this I added an ARG which can be passed to docker-build:
or if using docker-compose:
Note that FLOOD_BASE_URI does not need to be passed to docker-run.
FLOOD_BASE_URI variable is set in both "build" and "release" images which are part of Dockerfile.
Related Issue
Fixes #621
Context
These changes have been partially implemented in PR #837 but this PR is smaller in scope and contains only a non-breaking change.
How Has This Been Tested?
See commands above
Types of changes
Checklist: